Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace background with short-lived tasks #3842

Merged
merged 7 commits into from
Apr 20, 2023
Merged

refactor: replace background with short-lived tasks #3842

merged 7 commits into from
Apr 20, 2023

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Apr 11, 2023 •
edited
Loading

  • change target branch to rethnet/main

@Wodann Wodann requested review from alcuadrado and fvictorio April 11, 2023 16:22
@Wodann Wodann self-assigned this Apr 11, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 712898f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 10:10pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 10:10pm

@Wodann Wodann linked an issue Apr 12, 2023 that may be closed by this pull request
Optimise Rethnet to match EthereumJS runtime performance NomicFoundation/edr#66
Closed
1 task
fvictorio
fvictorio approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@fvictorio fvictorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one went over my head, so I'm just leaving some random questions from skimming the code

packages/hardhat-core/src/internal/core/providers/http.ts
@@ -264,7 +264,7 @@ export class HttpProvider extends EventEmitter implements EIP1193Provider {
): number | undefined {
const header = response.headers["retry-after"];

if (header === undefined || header === null) {
if (header === undefined || header === null || Array.isArray(header)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about this change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pato & I were debugging the tsc not recompiling after the native node add-on was updated and in the process re-installed the workspace. This updated one of our dependencies as well, resulting in this issue. Pato mentioned having fixed this on main this way, so we did that locally too

crates/rethnet_evm_napi/src/context.rs
#[derive(Debug)]
pub struct RethnetContext {
inner: Arc<Context>,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does NAPI-RS do with Arcs? I searched their docs but couldn't find it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing. This is a native Rust object that is exposed to JS using a handle.

Base automatically changed from rethnet/external-memory to rethnet/main April 20, 2023 21:54
@Wodann Wodann marked this pull request as ready for review April 20, 2023 22:09
@Wodann Wodann merged commit 41eafe2 into rethnet/main Apr 20, 2023
@Wodann Wodann deleted the rethnet/async-tasks branch April 20, 2023 22:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fvictorio fvictorio fvictorio approved these changes

@alcuadrado alcuadrado Awaiting requested review from alcuadrado

Assignees

@Wodann Wodann

Labels
area:edr status:triaging
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise Rethnet to match EthereumJS runtime performance
2 participants
@Wodann @fvictorio